Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog: Listing breaking changes #419

Open
codebycliff opened this issue Dec 4, 2017 · 9 comments
Open

Changelog: Listing breaking changes #419

codebycliff opened this issue Dec 4, 2017 · 9 comments
Labels

Comments

@codebycliff
Copy link

Would it be possible to list your breaking changes in the CHANGELOG.md for future releases? We have a bot that opens up pull requests for gem updates. This is the first gem update I have seen in quite a while that doesn't explicitly list the breaking changes. I can spot obvious ones (e.g. dropping support for ruby < 2.0), but I am not familiar with the codebase enough to determine other possible breaking changes from the list. Thanks!

@geemus
Copy link
Member

geemus commented Dec 6, 2017

Noted. I think the ruby version change is the only expected breaking change, fwiw.

@codebycliff
Copy link
Author

Thanks! Much appreciated.

@github-actions
Copy link

This issue has been marked inactive and will be closed if no further activity occurs.

@ryanb
Copy link

ryanb commented Mar 23, 2021

This has been closed, but I don't see a "breaking changes" section in the changelog.

I too would appreciate a section stating any breaking changes or simply state "No breaking changes" if there are none. It's difficult to automate the testing of AWS integration. Knowing if there are any breaking changes helps us to decide what level of manual testing is necessary when upgrading.

Either way, thanks for maintaining the gem!

@geemus
Copy link
Member

geemus commented Mar 23, 2021

@ryanb Hey. We do our best to use semantic versioning, so there shouldn't be breaking changes outside of a major release. It sounds like you might want it called out more explicitly for majors though. Do you have an example of a changelog that you think does this really well to help me maybe model after as I think about this?

@ryanb
Copy link

ryanb commented Mar 30, 2021

@geemus I like paper_trail's changelog which has three sections for each version: breaking changes, additions, and fixes. It states if there are "none" in the area.

Alternatively, a note at the top stating it's using semantic versioning, and breaking changes will only be in a major version would help.

Thanks!

@geemus
Copy link
Member

geemus commented Apr 2, 2021

@ryanb thanks for that. I expect semantic versioning, fwiw. Unfortunately the changelog is generated, so adding a notice isn't quite so easy. I suspect it shouldn't be TOO hard, but I'll need to dig in to make sure it doesn't just get clobbered/removed when we generate new changelogs in the future.

@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This issue has been marked inactive and will be closed if no further activity occurs.

@geemus
Copy link
Member

geemus commented Jun 2, 2021

Sorry still meaning to get to this, but just hasn't risen to a high priority. Will pin it at least to stop stale bot from bugging us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants