Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capped_cylinder API is confusing #41

Open
hweom opened this issue Aug 16, 2023 · 2 comments
Open

capped_cylinder API is confusing #41

hweom opened this issue Aug 16, 2023 · 2 comments

Comments

@hweom
Copy link

hweom commented Aug 16, 2023

Documentation says:

f = capped_cylinder(-Z, Z, 0.5)

But what are the first and the second arguments? I assume Z is an axis designator? Why does it need to be passed twice with opposite signs?

@nobodyinperson
Copy link

It's the start and end point of the cylinder.

@hweom
Copy link
Author

hweom commented Aug 17, 2023

Yeah, I eventually figured Z should be a unit vector for Z axis, although it's not explained anywhere.

It would be nice if the APIs for 3D primitives are normalized. For example, rounded_cylinder takes two radii and a height...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants