Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible wrong comment in synonym.html #25

Open
benoitv-code opened this issue May 1, 2013 · 0 comments
Open

Possible wrong comment in synonym.html #25

benoitv-code opened this issue May 1, 2013 · 0 comments

Comments

@benoitv-code
Copy link

In himera/resources/public/synonym.html, as far as I understand, I think the following comment should say values after 0 haven't been looked at as zero? (0 % 5) is true:

(def numbers [0 1 2 3 4 5 6 7 8 9 10])

(def filtered
  (filter #(zero? (rem % 5)) numbers))

(def firstn (first filtered))

;; lazy filter, values after 5 haven't
;; been looked at

Should be:

;; lazy filter, values after 0 haven't
;; been looked at

If the code really looks at the values up to 5, what do you think about adding a comment explaining why first looks at values up to the second occurrence?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant