Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot run npm install without errors #871

Closed
Bilal-S opened this issue Oct 7, 2018 · 7 comments
Closed

cannot run npm install without errors #871

Bilal-S opened this issue Oct 7, 2018 · 7 comments

Comments

@Bilal-S
Copy link

Bilal-S commented Oct 7, 2018

Receiving errors for attempts to run npm install no modification of code or attempts to do anything with the project when this happens. Started as git clone on windows.

using node 8.10.0

c:\Code\pdfkit>npm install
npm WARN prepublish-on-install As of npm@5, `prepublish` scripts are deprecated.
npm WARN prepublish-on-install Use `prepare` for build steps and `prepublishOnly` for upload-only.
npm WARN prepublish-on-install See the deprecation note in `npm help scripts` for more information.

> pdfkit@0.8.3 prepublish c:\Code\pdfkit
> make js

'make' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! pdfkit@0.8.3 prepublish: `make js`
npm ERR! Exit status 1
npm ERR!

There are more warnings and errors but this is the showstopper.

@danthegoodman
Copy link
Contributor

This will be resolved once the ES6 PR is merged in (#859), since it replaces the Makefile with npm scripts.

@Bilal-S
Copy link
Author

Bilal-S commented Oct 18, 2018

Thank you for taking time to respond.
Can you share with us an approximate timeline for this?

@danthegoodman
Copy link
Contributor

I'm not a maintainer or even a contributor, I just saw the issue and connected it with the PR I had been looking over. I'm not sure what their timeline is for that branch.

@ggaabe
Copy link

ggaabe commented Nov 28, 2018

Is this project even maintained anymore?

@haf
Copy link

haf commented Dec 30, 2018

@ggaabe It would seem so; lots of commits lately.

@haf
Copy link

haf commented Dec 30, 2018

This issue could be closed; npm install on tip of master works now.

@blikblum
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants