Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Use mission default" should be the default mission conditon #170

Closed
SamLex opened this issue Mar 31, 2018 · 7 comments
Closed

"Use mission default" should be the default mission conditon #170

SamLex opened this issue Mar 31, 2018 · 7 comments

Comments

@SamLex
Copy link
Member

SamLex commented Mar 31, 2018

For a number of the mission condition parameters in description.ext, the default value is something other than "Use mission default". This should be changed so that the mission conditions module does not override the editor settings unless a missionmaker or host changes the parameter

@NikkoJT
Copy link
Collaborator

NikkoJT commented Jul 17, 2018

As noted in comment on #172, while Weather and Time parameters use the "Use mission setting/s" phrasing, Fog and Wind parameters call it "Use default" instead.

The actual issue (using the mission setting by default) was correctly fixed by PR 172, this is just a string issue.

@SamLex
Copy link
Member Author

SamLex commented Jul 17, 2018

@shadow-fa Could you fix the inconsistent strings? Probably changing all to using "Use mission setting"

@shadow-fa
Copy link
Collaborator

Done in #180

@SamLex
Copy link
Member Author

SamLex commented Jul 18, 2018

Looks like f_param_fog and f_param_wind in description.ext use a hard coded "Use default" rather than the stringtable "Use mission setting".
https://github.com/Raptoer/F3/blob/d15923766844aa66f837f5cbcaf87fb548b88dde/description.ext#L176

These should be changed to reference the stringtable.

@shadow-fa
Copy link
Collaborator

Done in #180

@NikkoJT
Copy link
Collaborator

NikkoJT commented Feb 9, 2019

Confirmed correct in 3.5.2 test mission.

@SamLex SamLex closed this as completed Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants