Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORBAT notes briefing requires marker colors even for groups without a marker #279

Closed
darkChozo opened this issue Nov 8, 2019 · 1 comment

Comments

@darkChozo
Copy link
Collaborator

If you have an entry in groupData that doesn't specify a marker color, orbatNotes throws an error at line 50, even if a marker is not specified. This is inconsistent with the behavior of the group markers module.

Should be an easy fix; just resolve the marker color config later, and add in a check for whether the marker name is "" before adding the marker image.

repro: something like ["MyGroup","","","","Group - "] in groupData

@darkChozo darkChozo added the T:Bug label Nov 8, 2019
@shadow-fa shadow-fa added this to the 3.5.X milestone Nov 18, 2019
@shadow-fa
Copy link
Collaborator

#268 also seems to have fixed this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants