Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] transparent input errors #107

Closed
y0hami opened this issue Sep 4, 2018 · 7 comments
Closed

[Form] transparent input errors #107

y0hami opened this issue Sep 4, 2018 · 7 comments
Labels
lang/css Anything involving CSS tag/good-first-issue Good issues for new starters to try tag/help-wanted Issues which need help to fix or implement type/feat Any feature requests or improvements

Comments

@y0hami
Copy link
Member

y0hami commented Sep 4, 2018

Redesign how the transparent inputs display errors as discussed here #91

@y0hami y0hami added type/feat Any feature requests or improvements lang/css Anything involving CSS labels Sep 4, 2018
@y0hami y0hami added tag/help-wanted Issues which need help to fix or implement tag/good-first-issue Good issues for new starters to try labels Oct 5, 2018
@lubber-de
Copy link
Member

Before submitting a PR, i have 3 proposals:

a) Main visual problem is, a transparent input/textarea does not have any padding. But putting an error background to this, looks also strange then.
form_transparent_error_no_padding

b) Leaving the padding looks good in error case, but strange in normal case
form_transparent_error_padding

c) A combination of both. Stays without padding if fine. animates to padding in error case
form_transparent_error_animated_padding

Which option do you prefer?

@y0hami
Copy link
Member Author

y0hami commented Oct 8, 2018

I also ran into this when I did this, I like the animation you did but I'm not 100% maybe the other guys will have an opinion @fomantic/admins

I personally don't think adding padding to transparent inputs makes them look that bad but again I will wait for the others opinion.

@prudho
Copy link
Contributor

prudho commented Oct 9, 2018

Well, a is the worst IMHO, since the padding seems really weird on error. But I can't choose between b and c. Maybe the better is to stay close that non transparent input behaviors, so do not animate them.

@lubber-de
Copy link
Member

So @ColinFrick , whats your opinion?

@lubber-de
Copy link
Member

@prudho btw, keep in mind, in case of b) the current behaviour of SUI transparent input could be considered a breaking change, because there is actually no padding

@ColinFrick
Copy link
Member

IMHO option B fits nicely
I would add new input variables for transparent inputs:

@transparentPadding: @padding;
@transparentErrorBackground: @errorBackground;
@transparentErrorColor: @errorColor;

So if someone wants to revert to the previous transparent input he can just use these variables.

@y0hami
Copy link
Member Author

y0hami commented Oct 18, 2018

Added in 2.6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS tag/good-first-issue Good issues for new starters to try tag/help-wanted Issues which need help to fix or implement type/feat Any feature requests or improvements
Projects
None yet
Development

No branches or pull requests

4 participants