Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form/Input/Checkbox/Dropdown] Inconsistent inverted logic #158

Open
lubber-de opened this issue Oct 7, 2018 · 2 comments
Open

[Form/Input/Checkbox/Dropdown] Inconsistent inverted logic #158

lubber-de opened this issue Oct 7, 2018 · 2 comments
Labels
lang/css Anything involving CSS type/discussion Anything which is up for discussion

Comments

@lubber-de
Copy link
Member

Problem

The naming logic of inverted form elements is not consistent.
This could be considered a feature instead of a Bug but currently it's an inconsistent behaviour, which somehow breaks the "inverted" logic for Form Elements:

Input

has two inverted variants:

ui inverted input
image

ui inverted transparent input
image

Checkbox

has only one variant:
ui inverted checkbox
image

The matching "inverted transparent" variant according to input logic is completely missing for checkbox.

Dropdown

also has only one variant, But this time "inverted" is completely black without adding "transparent". This breaks the logic acording to input and checkbox
image

Textarea

does not have any inverted variant at all 😞

This does not feel consistent and makes clearly inverted forms using the default framework nearly impossible.

Solution

I suggest implementing the following class additions :

ui inverted transparent checkout
Suggested Example:
image

ui inverted transparent dropdown (which behaves as it currently is without "transparent")
ui inverted dropdown (that will be a breaking change)
ui inverted textarea
ui inverted transparent textarea

Poll

What do you guys think?

@prudho prudho added lang/css Anything involving CSS type/discussion Anything which is up for discussion labels Oct 8, 2018
@prudho
Copy link
Contributor

prudho commented Oct 8, 2018

Yes, I agree that the inverted variation is pretty inconsistent between different components. But for now Fomantic's purpose is to be fully compatible with Semantic, on already existing components, so we're tied with these inconsistencies for now. Maybe for an eventual 3.0 ! 😃

@y0hami
Copy link
Member

y0hami commented Oct 8, 2018

I do and don't agree with this, inverted and transparent are 2 different variations the only reason you get these results is because semantic "combines" them. I think this is due to the inverted variation not being implemented for every component like as you mentioned the textarea.

Currently if we implemented a inverted variation of the textarea you would be able to get the same results as the input component since textarea already has a transparent variation.

As for the checkbox/toggles I think it would be more suitable as ui inverted outline checkbox and ui inverted outline toggle because they aren't exactly "transparent".

The dropdown I do agree with and as you said it would be a breaking change so will have to wait but I think that is something we should do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/css Anything involving CSS type/discussion Anything which is up for discussion
Projects
None yet
Development

No branches or pull requests

3 participants