Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressLogging progress is not logged anywhere #1434

Closed
sethaxen opened this issue Sep 1, 2021 · 5 comments · Fixed by #437
Closed

ProgressLogging progress is not logged anywhere #1434

sethaxen opened this issue Sep 1, 2021 · 5 comments · Fixed by #437
Labels
logging About `@info`, `@warn`, etc

Comments

@sethaxen
Copy link

sethaxen commented Sep 1, 2021

On my machine, if I'm using a package that uses ProgressLogging to log progress, Pluto does not display that progress in the browser console, the REPL, or in the notebook; it seems to be inaccessible, whereas in the REPL, I would usually see some nice progress bar.

Is there a way that this can be adjusted within Pluto? The Turing and SciML stacks (among others) extensively use ProgressLogging, and IDEs like VSCode and Juno support displaying such progress logs.

@fonsp
Copy link
Owner

fonsp commented Sep 1, 2021

Linking #343

@sethaxen
Copy link
Author

sethaxen commented Sep 2, 2021

As I understand it, #343 is proposing Pluto adding progress meters for long-executing cells. Here I'm noting that Pluto is suppressing all existing ProgressLogging logs instead of logging them to the REPL/browser console like other logs. Perhaps this was done in #498?

A separate issue is that it would be nice if the Pluto UI could display such progress meters.

@fonsp
Copy link
Owner

fonsp commented Sep 4, 2021

Output currently looks like this:

image

In the REPL, there is no output by default, unless you also set up a logging display like TerminalLoggers.jl:

image

Setting up TerminalLogger in the repl before launching pluto has no effect

@fonsp fonsp linked a pull request Nov 3, 2021 that will close this issue
13 tasks
@joshualeond
Copy link

I see this issue is now closed due to the awesome new updates to Pluto.jl with logging and the ProgressLogging.jl functionality. So the behavior we should see now is more like the following in Pluto.jl:

image

However, when using Turing.jl and the AbstractMCMC.jl packages within Pluto.jl the progress info still seems to be suppressed for some reason. I do now see the logging messages but the progress bar still isn't working:

image

@sethaxen do you think this is an issue on the Pluto.jl side or more on the Turing.jl side?

@fonsp
Copy link
Owner

fonsp commented Jan 24, 2022

Nice! Can you open a new issue about this?

Repository owner locked and limited conversation to collaborators Jan 24, 2022
@fonsp fonsp added the logging About `@info`, `@warn`, etc label Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
logging About `@info`, `@warn`, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants