Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm v metrics info is consistent #2931

Open
davelab6 opened this issue Jun 15, 2020 · 6 comments
Open

Confirm v metrics info is consistent #2931

davelab6 opened this issue Jun 15, 2020 · 6 comments
Assignees

Comments

@davelab6
Copy link
Contributor

Observed behaviour

There are 4 places that GF currently has information about vertical metrics:

  1. https://github.com/googlefonts/gf-docs/tree/master/VerticalMetrics documentation
  2. FontBakery GF Profile VM check(s)
  3. https://github.com/googlefonts/gf-glyphs-scripts "Official" Google Fonts QA/Production scripts for Glyphs
    1.mf-glyphs-scripts Marc Foley's personal scripts for Glyphs. The QA > Check Font script can be useful

Over time these have drifted apart.

Expected behaviour

These must all be consistent.

@felipesanches
Copy link
Collaborator

We have other issues here that may (or may not) be related, but I'm referencing them here to avoid duplicates:

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 16, 2020

Thanks Felipe. I'll see if I can tackle all of them in one go. This week I'm focusing on font names, fvar instancers and STAT etc. I'll try and get to this within the next two weeks.

@felipesanches
Copy link
Collaborator

thanks, @m4rc1e. May I reassign this one to you?

@m4rc1e
Copy link
Collaborator

m4rc1e commented Jun 16, 2020

SGTM. I may need your help on this as well since there's quite a lot to do. Fancy a hangout next week? We need to run some tests before we can really do anything meaningful.

@felipesanches
Copy link
Collaborator

perfect! Let's schedule a call, call me in private ;-)

@RosaWagner
Copy link
Contributor

RosaWagner commented Jun 19, 2020

Since we are talking about updating the script, I would like to mentioned that right now caps are not centered with actual vertical metrics. Maybe you already discussed this, but it could be handy to have (-)TypoDescender = TypoAscender-CapsHeight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants