Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload should provide same update functionality as import from shared database #113

Closed
8 tasks done
wvengen opened this issue Apr 25, 2013 · 7 comments
Closed
8 tasks done
Labels
Milestone

Comments

@wvengen
Copy link
Member

wvengen commented Apr 25, 2013

If upload is used to add articles to a supplier, it may very well be that at some point later in time the same list needs to be updated from a similar file. Imports from the shared database do some checking to see if existing articles can be updated. It would be very nice if this functionality was present in upload too. They're basically the same thing anyway, in my view, with a different source (externally maintained database versus locally maintained list of articles in a spreadsheet which may come from the supplier directly too - after some column shuffling).

  • Fix title of import and sync article overview screen
  • Update upload screen text
  • Check if we need to be able to specify parameters for upload or not --> nope
  • Tests for upload: adding, updating and deleting articles.
  • Tests to check different file formats when uploading
  • Handle errors when form is incomplete (e.g. category empty)
  • Choose whether to take units from foodcoop or upload/shared_supplier
  • Add ability to delete/make unavailable products not in spreadsheet
@bennibu
Copy link
Contributor

bennibu commented May 11, 2013

yeah, nice idea. This shouldn't be so difficult.

@wvengen
Copy link
Member Author

wvengen commented May 11, 2013

Good news, thanks.

@wvengen
Copy link
Member Author

wvengen commented Jun 4, 2014

Anyone interested in implementing this in the next week or so? If not, I'll remove it from the 4.1 milestone.

@wvengen wvengen removed this from the 4.1 milestone Jun 7, 2014
@wvengen
Copy link
Member Author

wvengen commented Jan 18, 2015

I've finally started to work on this. A prototype is ready in branch feature/spreadsheets (which also enables importing Excel and OpenOffice files directly).

@wvengen wvengen added this to the 4.4 milestone Jan 18, 2015
@wvengen
Copy link
Member Author

wvengen commented Mar 27, 2015

Regarding upload options as csv column separator and encoding: this is not something that's possible right now. Besides, most people having a hard time specifying a csv column separator are probably better off using xls/xlsx/ods.

@wvengen
Copy link
Member Author

wvengen commented Mar 27, 2015

For an impression:
foodsoft_-upload_articles_of_de_lekkere_boer-_2015-03-27_17 39 12

The next form is the same as sync (except the title)
foodsoft_-upload_articles-_2015-03-27_17 37 58

@wvengen
Copy link
Member Author

wvengen commented Apr 10, 2015

That should be everything. There are two new checkboxes for controlling how the upload works. By default the settings were the same as before (no unit conversion, retain articles not in upload).
foodsoft_-upload_articles_of_doepiedoep-_2015-04-10_20 06 30

Suggestions for the user-interface and texts welcome, I think they can be better. Please test!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants