Speedup generating large PDFs #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvengen
force-pushed
the
feature/fix-document-preloading
branch
from
a000fc6
to
037e2a1
Compare
| @@ -36,7 +38,7 @@ def body | |||
| rows << [I18n.t('documents.order_by_groups.sum'), | |||
| order_article.tolerance > 0 ? "#{order_article.quantity} + #{order_article.tolerance}" : order_article.quantity, | |||
| sum[:quantity], | |||
| nil] #number_to_currency(sum[:price])] | |||
| number_to_currency(sum[:price])] | |||
There was a problem hiding this comment.
Need to review this change.
wvengen
force-pushed
the
feature/fix-document-preloading
branch
from
b36fd0a
to
5d6b2f1
Compare
|
|
||
| group_order_articles.each do |goa| | ||
| each_group_order_article_for(ordergroup) do |goa| | ||
| has_tolerance = true if goa.order_article.article.unit_quantity > 1 |
There was a problem hiding this comment.
needs to be goa.order_article.price.unit_quantity
3 tasks
wvengen
force-pushed
the
feature/fix-document-preloading
branch
from
5d6b2f1
to
b9bdd04
Compare
wvengen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow the PDF documents didn't do proper preloading. This adds it to all but the matrix document (let's do that one too later). Pending:
Might solve foodcoop-adam#174