Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added fix command #228

Merged
merged 9 commits into from
Oct 18, 2021
Merged

feat: added fix command #228

merged 9 commits into from
Oct 18, 2021

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Oct 10, 2021 •
edited
Loading

Description

This PR implements the fix command that allows to fix BDJuno issues without having to re-index the whole database at once.

Closes #227
Adds a way to fix #208

Checklist

  • Targeted PR against correct branch.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote unit tests.
  • Re-reviewed Files changed in the Github PR explorer.

@RiccardoM RiccardoM marked this pull request as ready for review October 18, 2021 08:44
MonikaCat
MonikaCat approved these changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Oct 18, 2021
@RiccardoM RiccardoM merged commit b81e781 into v2/cosmos/stargate Oct 18, 2021
@RiccardoM RiccardoM deleted the v2/cosmos/stargate-fix-command branch October 28, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonikaCat MonikaCat MonikaCat approved these changes

@huichiaotsou huichiaotsou huichiaotsou approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add fix command [LikeCoin] Proposal votes mismatch
3 participants
@RiccardoM @MonikaCat @huichiaotsou