-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CMD parse-genesis #257
Conversation
Before reviewing this, can you please fix the linting and tests @huichiaotsou? Also, when ready, can you mark this PR as ready for review? |
Hi @RiccardoM , I have changed it to ready for review. For the linter and test errors, it's because in juno I did 2 slight modification in order to separate parse cmd and parse genesis cmd, so I think those PR should be reviewed and merged first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested locally with #266
Codecov Report
@@ Coverage Diff @@
## v2/cosmos/stargate #257 +/- ##
=====================================================
Coverage ? 50.58%
=====================================================
Files ? 19
Lines ? 1870
Branches ? 0
=====================================================
Hits ? 946
Misses ? 796
Partials ? 128 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a lot of code duplication here that is not necessary
…2/aaron/parse_genesis_cmd � Conflicts: � go.mod � go.sum
Description
Closes: #246
Note: forbole/juno#30 and forbole/juno#31 will have to be merged
Add new command bdjuno parse-genesis to parse the genesis.json file
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change