Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add tombstoned information inside validator status #275

Merged
merged 11 commits into from
Dec 1, 2021
Merged

feat: add tombstoned information inside validator status #275

merged 11 commits into from
Dec 1, 2021

Conversation

huichiaotsou
Copy link
Contributor

Description

Closes: #274

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v2/cosmos/stargate@bb10ed3). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             v2/cosmos/stargate     #275   +/-   ##
=====================================================
  Coverage                      ?   50.58%           
=====================================================
  Files                         ?       19           
  Lines                         ?     1870           
  Branches                      ?        0           
=====================================================
  Hits                          ?      946           
  Misses                        ?      796           
  Partials                      ?      128

@huichiaotsou huichiaotsou marked this pull request as ready for review November 27, 2021 03:59
RiccardoM
RiccardoM reviewed Nov 29, 2021
View reviewed changes
database/schema/03-staking.sql Outdated Show resolved Hide resolved
database/staking_validators.go Outdated Show resolved Hide resolved
modules/staking/source/source.go Outdated Show resolved Hide resolved
modules/registrar.go Outdated Show resolved Hide resolved
@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Nov 30, 2021
@RiccardoM RiccardoM changed the title feat: add tombstoned status in validator_status feat: add tombstoned information inside validator status Nov 30, 2021
@RiccardoM RiccardoM added Status: Solved Should be solved, waiting for confirmation Status: Ready to merge and removed Status: Solved Should be solved, waiting for confirmation labels Nov 30, 2021
MonikaCat
MonikaCat approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on local

@mergify mergify bot merged commit cc38030 into v2/cosmos/stargate Dec 1, 2021
@mergify mergify bot deleted the aaron/tombstoned_validator branch December 1, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonikaCat MonikaCat MonikaCat approved these changes

@RiccardoM RiccardoM RiccardoM approved these changes

Assignees
No one assigned
Labels
automerge Automatically merge PR once all prerequisites pass Status: Ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add: tombstone to validator_status
4 participants
@huichiaotsou @codecov-commenter @RiccardoM @MonikaCat