Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated Hasura metadata #377

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Conversation

MonikaCat
Copy link
Contributor

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@MonikaCat MonikaCat added the automerge Automatically merge PR once all prerequisites pass label Apr 4, 2022
@RiccardoM RiccardoM changed the title feat: updated hasura metadata (v3.0.0) chore: updated Hasura metadata Apr 5, 2022
Copy link
Contributor

@RiccardoM RiccardoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall, although I see some things that might not be really useful like transactionByPartitionIdTransactionHash and messagesByTransactionHashPartitionId. If they are not used, I think we can simply delete them.

We should also go through the overall metadata to make sure there are no useless relationships there and clean them up

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v2/cosmos/stargate@5e6619a). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                  @@
##             v2/cosmos/stargate     #377   +/-   ##
=====================================================
  Coverage                      ?   57.58%           
=====================================================
  Files                         ?       17           
  Lines                         ?     1339           
  Branches                      ?        0           
=====================================================
  Hits                          ?      771           
  Misses                        ?      472           
  Partials                      ?       96           

Copy link
Contributor

@huichiaotsou huichiaotsou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested Ack

@mergify mergify bot merged commit 0d44ceb into v2/cosmos/stargate Apr 6, 2022
@mergify mergify bot deleted the m/update-hasura-metadata branch April 6, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants