Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gov v1 proposals #610

Merged
merged 15 commits into from
Jun 29, 2023
Merged

Conversation

RiccardoM
Copy link
Contributor

Description

This PR aims at updating the codebase in order to properlty support x/gov new v1 proposal types and inner workings.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Merging #610 (998f8dd) into cosmos/v0.47.x (a724b93) will increase coverage by 0.93%.
The diff coverage is 42.00%.

@@                Coverage Diff                 @@
##           cosmos/v0.47.x     #610      +/-   ##
==================================================
+ Coverage           54.96%   55.90%   +0.93%     
==================================================
  Files                  19       20       +1     
  Lines                1479     1431      -48     
==================================================
- Hits                  813      800      -13     
+ Misses                565      536      -29     
+ Partials              101       95       -6     

@RiccardoM RiccardoM marked this pull request as ready for review June 26, 2023 20:41
@RiccardoM RiccardoM requested a review from MonikaCat June 26, 2023 20:41
database/gov.go Outdated Show resolved Hide resolved
database/gov.go Outdated Show resolved Hide resolved
@MonikaCat
Copy link
Contributor

Nice! I also updated hasura metadata and added entry inside CHANGELOG.md, thanks @RiccardoM !

Copy link
Contributor

@MonikaCat MonikaCat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, LGTM

@MonikaCat MonikaCat merged commit 67a1737 into cosmos/v0.47.x Jun 29, 2023
@MonikaCat MonikaCat deleted the riccardom/gov-v1-proposal branch June 29, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants