Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

Wrong number of total validators and delegated tokens #29

Closed
kwunyeung opened this issue Apr 21, 2019 · 4 comments
Closed

Wrong number of total validators and delegated tokens #29

kwunyeung opened this issue Apr 21, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@kwunyeung
Copy link
Member

image

The total number of validators and total number of delegated tokens are wrong as the BD get all validators from the LCD and there is a bug cosmos/cosmos-sdk#4099
@kwunyeung kwunyeung added the bug Something isn't working label Apr 21, 2019
@kwunyeung
Copy link
Member Author

Same as in IRIS

image

@ztsai
Copy link
Contributor

ztsai commented May 3, 2019

it's still not correct after upgrading to v0.34.2
The actual count is 124 but home page shows 111 while validator page shows 120(active+inactive)
we only add a validator to database when it becomes or falls out of active validators. The ones that have been unbonded/unbonding before the fix came out are still not added.
Screen Shot 2019-05-03 at 10 05 30 AM

Screen Shot 2019-05-03 at 10 02 29 AM
Screen Shot 2019-05-03 at 10 02 40 AM
Screen Shot 2019-05-03 at 10 02 47 AM

@ztsai ztsai reopened this May 3, 2019
@kwunyeung
Copy link
Member Author

Should upsert the data to the collection even if they haven't validated any block.

@kwunyeung
Copy link
Member Author

Fixed in 637d546. The total number of validators didn't save before.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kwunyeung @ztsai