-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to use @salesforce/bunyan #211
Conversation
@@ -38,11 +38,11 @@ | |||
} | |||
}, | |||
"dependencies": { | |||
"@salesforce/bunyan": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amphro looks like we still run tests for NodeJS 8 but I made changes to bunyan that specify it should be used on NodeJS 10 and above. Which version should be the min version we support here and on bunyan ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change it to node10 and node12
@@ -38,11 +38,11 @@ | |||
} | |||
}, | |||
"dependencies": { | |||
"@salesforce/bunyan": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can change it to node10 and node12
7ebe811
to
5ec3c72
Compare
Codecov Report
@@ Coverage Diff @@
## develop #211 +/- ##
==========================================
Coverage ? 85.96%
==========================================
Files ? 34
Lines ? 2052
Branches ? 156
==========================================
Hits ? 1764
Misses ? 247
Partials ? 41 Continue to review full report at Codecov.
|
5ec3c72
to
2fed62b
Compare
2fed62b
to
4c226c6
Compare
## [2.3.1](v2.3.0...v2.3.1) (2020-04-13) ### Bug Fixes * use new @salesfore/bunyan library, run tests in node 10 & 12 ([#211](#211)) ([249850d](249850d))
🎉 This PR is included in version 2.3.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Update the project to use @salesforce/bunyan which uses dayjs. DayJS being a lighter library compared to moment. This is the first step into making @salesforce/core compatible with bundler tools like webpack, rollup, etc.
@W-6980157@