Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use @salesforce/bunyan #211

Merged
merged 1 commit into from
Apr 7, 2020
Merged

Update to use @salesforce/bunyan #211

merged 1 commit into from
Apr 7, 2020

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Apr 1, 2020

Update the project to use @salesforce/bunyan which uses dayjs. DayJS being a lighter library compared to moment. This is the first step into making @salesforce/core compatible with bundler tools like webpack, rollup, etc.

@W-6980157@

@lcampos lcampos requested review from amphro, shetzel and mdonnalley April 1, 2020 20:34
@@ -38,11 +38,11 @@
}
},
"dependencies": {
"@salesforce/bunyan": "^2.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amphro looks like we still run tests for NodeJS 8 but I made changes to bunyan that specify it should be used on NodeJS 10 and above. Which version should be the min version we support here and on bunyan ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change it to node10 and node12

@@ -38,11 +38,11 @@
}
},
"dependencies": {
"@salesforce/bunyan": "^2.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can change it to node10 and node12

@lcampos lcampos force-pushed the lcampos/update-bunyan branch from 7ebe811 to 5ec3c72 Compare April 7, 2020 22:35
@codecov-io
Copy link

codecov-io commented Apr 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (develop@44de6f0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #211   +/-   ##
==========================================
  Coverage           ?   85.96%           
==========================================
  Files              ?       34           
  Lines              ?     2052           
  Branches           ?      156           
==========================================
  Hits               ?     1764           
  Misses             ?      247           
  Partials           ?       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44de6f0...5ec3c72. Read the comment docs.

@lcampos lcampos force-pushed the lcampos/update-bunyan branch from 5ec3c72 to 2fed62b Compare April 7, 2020 23:08
@lcampos lcampos force-pushed the lcampos/update-bunyan branch from 2fed62b to 4c226c6 Compare April 7, 2020 23:11
@lcampos lcampos merged commit 249850d into develop Apr 7, 2020
@lcampos lcampos deleted the lcampos/update-bunyan branch April 7, 2020 23:14
amphro pushed a commit that referenced this pull request Apr 13, 2020
## [2.3.1](v2.3.0...v2.3.1) (2020-04-13)

### Bug Fixes

* use new @salesfore/bunyan library, run tests in node 10 & 12 ([#211](#211)) ([249850d](249850d))
@amphro
Copy link
Collaborator

amphro commented Apr 13, 2020

🎉 This PR is included in version 2.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants