Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logger binding #596

Merged
merged 2 commits into from
May 31, 2024
Merged

fix: logger binding #596

merged 2 commits into from
May 31, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented May 31, 2024

What does this PR do?

bind the logger methods to the pinoLogger instance.

before, it's possible with SF_LOG_LEVEL=trace to cause
Error (10): Cannot read properties of undefined (reading 'Symbol(pino.msgPrefix)')
when doing remoteSourceTracking operations

reproducible using project deploy start.

What issues does this PR fix or reference?

@mshanemc mshanemc requested a review from a team as a code owner May 31, 2024 19:23
@cristiand391 cristiand391 merged commit aab471d into main May 31, 2024
32 checks passed
@cristiand391 cristiand391 deleted the sm/logger-binding branch May 31, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants