verify sub command can't be used on root of workspace (find can be used)

[eitsupi]

I have tried the new cargo-msrv and it seems that cargo-msrv msrv find supports workspaces root (great!) but not verify.
It seems that verify can't get the version from workspace.package.rust-version.

Originally posted by @eitsupi in #590 (comment)

[foresterre]

Thanks! I'll have a look

[foresterre]

Could you describe what you did and what you expected to happen?

I tried to reproduce it, but here it seems to work as expected:

[eitsupi]

Thanks for your quick response!

My intention was to use the verify command at the root of the workspace rather than in a subdirectory. (To verify workspace.package.rust-version, which was found by the find command)
It works fine for subdirectories (individual crates) as in your example.

[foresterre]

Are you in a virtual workspace or does your crate also have a root package?

If it is a virtual workspace, what kind of behaviour did you expect from cargo-msrv (or any cargo plugin which reads from the workspace.package table)? 😄

As far as I am aware, the keys in the workspace.package table are solely to share their values between workspace members, and aren't meant to pin the value for the workspace as a whole. Note that inheriting packages need to explicitely say it, if they want to inherit the key from the workspace.

What I can imagine however, is that the behaviour you're looking for is that running cargo msrv verify --workspace, verifies all packages in the workspace.

The difficulty with doing this by default, i.e. when running cargo msrv verify from a workspace root, is that you'll have to disambiguate between "running verify against a root package" or "running verify against all workspace members plus the root package"

[eitsupi]

If it is a virtual workspace, what kind of behaviour did you expect from cargo-msrv (or any cargo plugin which reads from the workspace.package table)? 😄

As far as I am aware, the keys in the workspace.package table are solely to share their values between workspace members, and aren't meant to pin the value for the workspace as a whole. Note that inheriting packages need to explicitely say it, if they want to inherit the key from the workspace.

Thank you for clarifying this.
I mistakenly thought it represented the MSRV of the entire workspace because the find command worked.

Perhaps find should also fail in the virtual workspace root? 🤔

There is no doubt that what I am ultimately looking for is a command to display the MSRV of all the crates at once.

[max-sixty]

The difficulty with doing this by default, i.e. when running cargo msrv verify from a workspace root, is that you'll have to disambiguate between "running verify against a root package" or "running verify against all workspace members plus the root package"

I would have imagined that it would inherit the behavior of cargo — use the default workspace members — which is the root if one exists, or all members if one doesn't exist or --workspace is passed.

(along with @eitsupi, I'm a dev of prql. I'm separately a maintainer of insta, where we do exactly that)

[foresterre]

The difficulty with doing this by default, i.e. when running cargo msrv verify from a workspace root, is that you'll have to disambiguate between "running verify against a root package" or "running verify against all workspace members plus the root package"

I would have imagined that it would inherit the behavior of cargo — use the default workspace members — which is the root if one exists, or all members if one doesn't exist or --workspace is passed.

(along with @eitsupi, I'm a dev of prql. I'm separately a maintainer of insta, where we do exactly that)

Thanks for the feedback!

I never realized that the following is the cargo default for a virtual workspace:

or all members if one doesn't exist

I agree that inheriting cargo's behavior is most logical.