Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom check? #812

Closed
polarathene opened this issue Oct 26, 2023 · 4 comments
Closed

Custom check? #812

polarathene opened this issue Oct 26, 2023 · 4 comments

Comments

@polarathene
Copy link

I recently tried cargo-msrv on a project and it correctly detected the MSRV which is a great.

Another user noticed the CI did not like the MSRV though, and that was due to the MSRV for dev-dependencies was different. cargo check --tests for example would fail.

Is this something cargo-msrv could also support? It seems it'd just need to support adjusting the check command to allow setting options?

@polarathene
Copy link
Author

Looks like this was being tackled in May?:

Related issues:

@foresterre
Copy link
Owner

In today's cargo msrv, you can run cargo msrv -- cargo check --tests to run cargo msrv with your command.

Would this resolve your question?

@polarathene
Copy link
Author

Yes! Sorry, I see that this was actually covered on the README and CLI help output. For some reason I completely missed it from both 😬

I had tried searching through the issues (and open PRs as linked above), thinking this hadn't been covered. The README has had it since Jan 2022, and in Dec 2022 an example specifically for this cargo check --tests command was contributed 😓


For quick reference if anyone lands on this issue:

image

image

image

@foresterre
Copy link
Owner

No worries! Glad it works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants