Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

「Feature Request」detached HEAD should show in left Branches area #107

Closed
yam-liu opened this issue Sep 27, 2017 · 11 comments
Closed

「Feature Request」detached HEAD should show in left Branches area #107

yam-liu opened this issue Sep 27, 2017 · 11 comments
Labels

Comments

@yam-liu
Copy link

yam-liu commented Sep 27, 2017

When checkout to a commit without tag, you have a detached HEAD.
git status will show

HEAD detached from 1d9d44eef
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

        modified:   a.c
        modified:   b.c

no changes added to commit (use "git add" and/or "git commit -a")

In SourceTree, the left Branches area has a HEAD "branch" flag, click it will lead you to the commit. But in Fork, I can not find that commit I have checked out, unless I scroll from the long long commit history.
image

@DanPristupov
Copy link
Contributor

Sorry for the delay. I like the idea. I'll try to implement this in the next release.

@bwl21
Copy link

bwl21 commented Nov 29, 2017

Yes please, this is a blocker for me to swith from sourcetree.

@DanPristupov
Copy link
Contributor

DanPristupov commented Nov 29, 2017

@bwl21 sounds like a good reason to increase priority of the task :). It's going to be done in 1.0.60.

@DanPristupov
Copy link
Contributor

@ooopscc @bwl21 this feature is finally available in 1.0.60

@bwl21
Copy link

bwl21 commented Dec 1, 2017

Very cool. Now we can see that we are on a detached head.
I am afraid I propose to do more:

Here is a situation in fork,

screenshot_1046

  • love the idea to visualize the stashes in the history tree.
  • I would also like to see the HEAD visualized in the history tree
  • I would also like the "uncommitted changes" in the history tree

Here is what I expected (Sorry Atlassian, I shameless copy Sourcetree's beahavior). But this visualization is the coolest approach I have seen for this.

screenshot_1045

@bwl21
Copy link

bwl21 commented Dec 28, 2017

is there any chance that you come closer to sourcetree's approach. In particular it is not always visible if there are uncommitted changes.

An earlier version (before 1.0.61) showed a number of uncommitted changes on the "Changes" entry in the left pane. But with 1.0.61 even this seems to be gone.

edit: maybe it is gone due to #147

@bwl21
Copy link

bwl21 commented Feb 26, 2018

@DanPristupov why do you close this issue? is it fixed or wontfix.

@DanPristupov
Copy link
Contributor

Depends on what you mean. Fork shows HEAD in the branch list on the sidebar in detached HEAD state, which was the original request.

@DanPristupov
Copy link
Contributor

I would also like to see the HEAD visualized in the history tree

It's probably excessive to show such a label all the time, but I can show it in Detached HEAD state.

I would also like the "uncommitted changes" in the history tree

What's the point of this? It seems strange to show a fake revision which semi-duplicates the "Changes" view.

@bwl21
Copy link

bwl21 commented Feb 26, 2018

Well it is how Sourcetree does it (which is where I came from). The way fork currently does it is also reasonable after one got used to it.

Thanks for the explanation.

@DanPristupov
Copy link
Contributor

Ok, going to keep that issue closed. Please let me know if I'm missing something and feel free to create a separate issue if you have some idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants