Skip to content
This repository has been archived by the owner on Jul 20, 2022. It is now read-only.

Unit test our JS functions #12

Open
ChristofLee opened this issue Oct 30, 2017 · 3 comments
Open

Unit test our JS functions #12

ChristofLee opened this issue Oct 30, 2017 · 3 comments

Comments

@ChristofLee
Copy link
Collaborator

This is overkill but good practice.

I would achieve this using Jest.

You would then need to implement browserify to enable module.export and require.

@PrabhanshuAttri
Copy link
Contributor

Unit testing is a good idea. Let's put this in future works. Once the JS code is separated and minified, we can add tests as well.

@ChristofLee
Copy link
Collaborator Author

I can do this if you (@PrabhanshuAttri) approve the method I mentioned above?

Assign this to me and I will make a PR for this issue.

@PrabhanshuAttri
Copy link
Contributor

Go ahead. Make sure you create a separate PR for this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants