Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change constrains of react and react-dom versions to allow version 18 #3526

Closed
wants to merge 2 commits into from
Closed

change constrains of react and react-dom versions to allow version 18 #3526

wants to merge 2 commits into from

Conversation

jancajthaml
Copy link
Contributor

@jancajthaml jancajthaml commented Apr 9, 2022 •
edited
Loading

Support react 18 #3510

@jancajthaml
Copy link
Contributor Author

jancajthaml commented Apr 12, 2022 •
edited
Loading

@types/react 18 breaking changes DefinitelyTyped/DefinitelyTyped#56210 .

No impact observed in this repo, elements with children already has children in their Props declared.

Nitpicking in tests and README SFC -> FC but that has no real impact.

@longlho longlho closed this in 8808a95 Apr 17, 2022
@longlho
Copy link
Member

longlho commented Apr 17, 2022

Thanks a lot for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jancajthaml @longlho