-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[regression >3.1.1] Type generics annotation do not get forwarded to FormattedMessage #1412
Comments
@longlho what do you think? What is your preference for this? I guess we should either remove the HOC or forward the types. I can open a PR if you point me in the right direction. |
unfortunately we can't fully use hooks yet per #1290 (comment) so forwarding type would be best rn. PR's always welcome! |
I see, thanks for the info. I'll look into forwarding types then. |
longlho
pushed a commit
that referenced
this issue
Aug 13, 2019
longlho
pushed a commit
that referenced
this issue
Aug 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This commit 660a546 changed the exported component
message
component to be wrapped withinjectIntl
.However, I believe that this change broke the TS generics, as the type of the values field does not get forwarded anymore.
Before I could do:
But now it breaks because the generic type that I pass gets ignored
Can the component be rewritten using react hooks?
The text was updated successfully, but these errors were encountered: