Not using React state for swipe state #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The state used for
x
,y
,swiping
andstart
aren't used in the render methods (nothing is supposed to happen really, as it's up to the user ofreact-swipeable
to perform any x/y-translations), and using setState() will trigger React logic to perform things which may cause stuttering and slow down transitions, etc.This PR will save the state in a local variable
this.swipable
instead of the React state, to ensure we bypass all React state logic, since it's not needed.