Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to react 15.5.x #64

Merged
merged 3 commits into from
Apr 13, 2017
Merged

migrate to react 15.5.x #64

merged 3 commits into from
Apr 13, 2017

Conversation

rdy
Copy link
Contributor

@rdy rdy commented Apr 8, 2017

To avoid warning is React 15.5.x:

  • remove createClass, replace with ES6 class
  • use prop-types package

package.json Outdated
@@ -55,6 +55,7 @@
"react-dom": "^15.4.2"
},
"peerDependencies": {
"prop-types": "^15.0.0-0",
"react": ">=0.12.0 || ^15.0.0-0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update this peer dep to "react": "^0.14.0 || ^15.0.0-0 || ^16.0.0-0" since v12 and v13 dont support extend React.Component?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing

@hartzis hartzis merged commit ca61825 into FormidableLabs:master Apr 13, 2017
@github-actions github-actions bot mentioned this pull request May 18, 2023
@paulmarsicloud paulmarsicloud mentioned this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants