docs(readme): add usage section #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 332 332
Branches 50 50
=========================================
Hits 332 332 Continue to review full report at Codecov.
|
MahdiAbdi
reviewed
Jan 8, 2022
MahdiAbdi
reviewed
Jan 8, 2022
README.md
Outdated
| ``` | ||
|
|
||
| - you need to refactor all `FancyInput` usage, pass `value`, and `setValue` to make it work as expected | ||
| - the top-level component (`FancyList`) re-render each time the `filter` changes |
There was a problem hiding this comment.
Suggested change
| - the top-level component (`FancyList`) re-render each time the `filter` changes | |
| - the top-level component (`FancyList`) re-renders each time the `filter` changes. |
|
|
||
| react-wire have more advanced features: | ||
|
|
||
| - selectors to maintain calculated values |
There was a problem hiding this comment.
Are you going to suffice with this amount of explanation for the advanced features?
There was a problem hiding this comment.
For now, Yes. I will add an example directory in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.