Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libcurl instead of hacky HTTP download code #2

Closed
vgmoose opened this issue Mar 6, 2018 · 3 comments
Closed

Use libcurl instead of hacky HTTP download code #2

vgmoose opened this issue Mar 6, 2018 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vgmoose
Copy link
Member

vgmoose commented Mar 6, 2018

In Utils.cpp, on Switch targets, libcurl isn't able to be used. This results in slower, unreliable http download code.

@vgmoose vgmoose added enhancement New feature or request help wanted Extra attention is needed labels Mar 6, 2018
@vgmoose
Copy link
Member Author

vgmoose commented Mar 28, 2018

There's a libcurl portlib available on dkp-pacman, but using it results in the following compilation error:

/opt/devkitpro/portlibs/switch/lib/libcurl.a(libcurl_la-mime.o): In function curl_mime_filedata':
mime.c:(.text+0x1a50): undefined reference toaccess'
/opt/devkitpro/portlibs/switch/lib/libcurl.a(libcurl_la-timeval.o): In function Curl_now':
timeval.c:(.text+0x10): undefined reference toclock_gettime'
collect2: error: ld returned 1 exit status
make[1]:  Error 1

@Black-Seraph
Copy link

What's your problem exactly? Removed the -DNOCURL flag, added -lcurl, and all builds flawlessly and works fine.

@vgmoose
Copy link
Member Author

vgmoose commented Aug 28, 2018

You're right! It used to be crashing my Switch (after resolving the above mentioned build problems) but with the latest libcurl package everything looks good.

Removed NOCURL code from fortheusers/libget@2338da5
Updated progress bar to use curl's progress callback: 023373a

@vgmoose vgmoose closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants