Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do something about long initial load #25

Closed
vgmoose opened this issue Oct 28, 2018 · 2 comments
Closed

Do something about long initial load #25

vgmoose opened this issue Oct 28, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vgmoose
Copy link
Member

vgmoose commented Oct 28, 2018

The initial load takes a while because it has to fetch all icon/banner images for every app, and as more apps are added to the store this load becomes slower and slower.

Some possible solutions:

  • try to download images in parallel instead of sequentially
  • download a zip of all the images if a significant portion of the images are missing (would need Add callback for progress while extracting #24 and Apps with lots of files are sloooow to install #5 fixed though)
  • download images "on demand" when they are viewed in the list/detailes view instead of during the first load (and in another thread)
  • "just" have networking in general faster be faster on the switch (pretty sure homebrew network speed isn't as fast as nintendo's speeds, but have no proof to back up this claim)

As of 2.0, it does re-use the http socket, which has helped a bit, but it's still too slow for the first load

@vgmoose vgmoose added enhancement New feature or request help wanted Extra attention is needed labels Oct 28, 2018
@vgmoose
Copy link
Member Author

vgmoose commented Mar 30, 2019

I've tried downloading a zip of images, and it seems to be a wash in terms of extraction time vs download time.

I think the real mistake of the initial load was having banners be as large as they are, and loaded at the start. On Wii U, we've skipped the banners altogether and the initial load is much less frustrating.

As a rest of this, I think the only true solution to this issue is the third bullet note, downloading them "on demand" in a few worker threads, and upon visiting the app details page in the background.

This should also open up more flexibility like having multiple screenshots in the details view per app.

@vgmoose
Copy link
Member Author

vgmoose commented Nov 28, 2019

The initial loading screen has been completely removed thanks to @rw-r-r-0644 's NetImage changes! (merge commit)

@vgmoose vgmoose closed this as completed Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant