Skip to content

haskel version takes commit= keyword on a dependency, the Fortran prototype does not #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
urbanjost opened this issue Sep 21, 2020 · 2 comments

Comments

@urbanjost
Copy link
Contributor

Given a dependency with a specific git(1) commit value

[dependencies.M_CLI2]
git = "https://github.com/urbanjost/M_CLI2.git"
commit = "a177b0077819571815fa6a8da6980bcb45443858"
The Fortran fpm(1) prototype complains about the commit keyword

fpm run --args build
Key commit is not allowed in dependency M_CLI2
ERROR STOP 1

Error termination. Backtrace:
#0 0x7f9497368131 in ???
#1 0x7f9497368cd9 in ???
#2 0x7f9497369e9b in ???
#3 0x404570 in fpm_MOD_cmd_build
at src/fpm.f90:101
#4 0x401977 in MAIN

at app/main.f90:22
#5 0x401a20 in main
at app/main.f90:8

but it builds OK with the haskell version

[urbanjs@localhost fpm]$ fpm build
[urbanjs@localhost fpm]$

It looks like the commit= keyword was not enabled?

@LKedward
Copy link
Member

Apologies, I was mistaken in my suggestion for #181; the correct syntax for specifying a commit is rev=. This is for both versions of fpm.

Haskell fpm does not verify the manifest file and so won't complain about commit being incorrect.

@urbanjost
Copy link
Contributor Author

Well, the good and the bad about a full verification. In this case good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants