Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpm_model_t serialization #877

Closed
3 tasks
perazz opened this issue Apr 12, 2023 · 1 comment
Closed
3 tasks

fpm_model_t serialization #877

perazz opened this issue Apr 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@perazz
Copy link
Contributor

perazz commented Apr 12, 2023

Description

As discussed here, it is desirable to have fpm be able to fully serialize/deserialize fpm_model_tvariables to/from TOML or JSON.
Relevant discussion at 40:25 and 42:55 mins

Possible Solution

  • create an abstract serializable_t class which implements the serialization APIs
  • enforce all relevant classes inside fpm_model_t to extend serializable_t
  • write implementation routines for each of them

Additional Information

  • If the fpm model is serializable, it's JSON can be sent via REST API so the registry can validate a package without having to download all dependencies and build the model in the backend. API for deleting package. registry#9

  • serialization/deserialization should change none of the contents of the fpm_model_t (i.e., path variables should not change) but just provide an automated way to load it back/forth

@perazz perazz added the enhancement New feature or request label Apr 12, 2023
@perazz
Copy link
Contributor Author

perazz commented Mar 25, 2024

This has been merged, so I will close this issue.

@perazz perazz closed this as completed Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant