-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triple zero output for numbers ending with double zero #124
Comments
Thank you for reporting this. I'll take a look later and hopefully resolve this today. |
I can see how https://github.com/forzagreen/n2words/blame/ab74750586e77b63ac3b1ec073c74495c916fa2d/lib/classes/AbstractLanguage.js#L87 would create a 0 from the remaining output ("") in these events. I am working on a fix, but it may take until this weekend. |
Merged in #125 and will put out a release later today. Thanks again for reporting! |
Had a quick look at the changes, and it seems like this would fix it indeed. Will test and check out the new code once it is released. Thanks for all your hard work and rapid response! |
Released in v1.17.0 🎉 |
Using the default config for multiple languages (NL, EN, DE) (I did not test all) makes numbers ending with double zeros output to a value with triple zeros.
Faulty tests in EN:
It only happens for numbers ending with double zero. Correct tests in EN:
The text was updated successfully, but these errors were encountered: