fix: resolve PDF download issues (#1256)

* fix: resolve PDF download issues #1245 #1247

- Fix duplicate .pdf extension in ticket filenames by removing redundant provider identifier
- Add defensive null checks for order_position to prevent HTTP 500 errors
- Apply consistent filename format across presale, control, and API views
- Filenames now follow clean pattern: EVENT-CODE-POSITION.pdf

Fixes #1245: HTTP 500 error on confirmation page PDF download
Fixes #1247: Duplicate .pdf extension in ticket filename

* fix: correct extra closing brace in filename format string

Fixes syntax error where fallback filename
had an extra '}' character causing malformed filenames.

* fix: remove unnecessary null checks in PDF download

---------

Co-authored-by: Mario Behling <mb@mariobehling.de>
Co-authored-by: Srivatsav Auswin <75414859+Sak1012@users.noreply.github.com>

Author: 3 people

app/eventyay/api/views/order.py

@@ -296,10 +296,9 @@ def download(self, request, output, **kwargs):
                 return resp
             else:
                 resp = FileResponse(ct.file.file, content_type=ct.type)
-                resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
+                resp['Content-Disposition'] = 'attachment; filename="{}-{}{}"'.format(
                     self.request.event.slug.upper(),
                     order.code,
-                    provider.identifier,
                     ct.extension,
                 )
                 return resp
@@ -1094,11 +1093,10 @@ def download(self, request, output, **kwargs):
                 return resp
             else:
                 resp = FileResponse(ct.file.file, content_type=ct.type)
-                resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(
+                resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
                     self.request.event.slug.upper(),
                     pos.order.code,
                     pos.positionid,
-                    provider.identifier,
                     ct.extension,
                 )
                 return resp

app/eventyay/control/views/orders.py

@@ -510,20 +510,18 @@ def success(self, value):
                 return resp
             else:
                 resp = FileResponse(value.file.file, content_type=value.type)
-                resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(
+                resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
                     self.request.event.slug.upper(),
                     self.order.code,
                     self.order_position.positionid,
-                    self.output.identifier,
                     value.extension,
                 )
                 return resp
         elif isinstance(value, CachedCombinedTicket):
             resp = FileResponse(value.file.file, content_type=value.type)
-            resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
+            resp['Content-Disposition'] = 'attachment; filename="{}-{}{}"'.format(
                 self.request.event.slug.upper(),
                 self.order.code,
-                self.output.identifier,
                 value.extension,
             )
             return resp

app/eventyay/presale/views/order.py

@@ -1087,29 +1087,26 @@ def success(self, value):
                 resp = FileResponse(value.file.file, content_type=value.type)
                 if self.order_position.subevent:
                     # Subevent date in filename improves accessibility e.g. for screen reader users
-                    resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}-{}{}"'.format(
+                    resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(
                         self.request.event.slug.upper(),
                         self.order.code,
                         self.order_position.positionid,
                         self.order_position.subevent.date_from.strftime('%Y_%m_%d'),
-                        self.output.identifier,
                         value.extension,
                     )
                 else:
-                    resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}-{}{}"'.format(
+                    resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
                         self.request.event.slug.upper(),
                         self.order.code,
                         self.order_position.positionid,
-                        self.output.identifier,
                         value.extension,
                     )
                 return resp
         elif isinstance(value, CachedCombinedTicket):
             resp = FileResponse(value.file.file, content_type=value.type)
-            resp['Content-Disposition'] = 'attachment; filename="{}-{}-{}{}"'.format(
+            resp['Content-Disposition'] = 'attachment; filename="{}-{}{}"'.format(
                 self.request.event.slug.upper(),
                 self.order.code,
-                self.output.identifier,
                 value.extension,
             )
             return resp