Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sendgrid api instead of http.client to send mails. #315

Open
rahulkumaran opened this issue Oct 20, 2018 · 4 comments
Open

Use sendgrid api instead of http.client to send mails. #315

rahulkumaran opened this issue Oct 20, 2018 · 4 comments

Comments

@rahulkumaran
Copy link
Contributor

  • Issue type: Feature request

Short description

As far as I know, Sendgrid is being used to send the ISO is ready email to the users. Why not simply use the sendgrid python wrapper instead of the http.client? That would decrease the space complexity too be a great amount.

Expected behaviour

Same as actual. Just that it would be done in a fewer number of lines.

Actual behaviour

Sending an email only.

Usecase

Decrease space complexity and leave all the work to the sendgrid wrapper. We just focus on shipping good code. Plus we get the right error codes too using the api.

Description

Meilix would still send the mail but instead of using http.client module, we could simply use the sendgrid module. This would decrease space complexity and leave all the background work to the wrapper and we can simply focus on sending the email to the user.

@meets2tarun
Copy link
Member

We can have this issue for GCI advanced level tasks. What do you say?

@rahulkumaran
Copy link
Contributor Author

Sure! Totally cool with that @meets2tarun

Incase nobody takes this up and solves it by the end of GCI, then I'd like to solve this !

@tabesin
Copy link
Member

tabesin commented Nov 21, 2018

Great! Just tell me what you need from our side to get started. The running GCI should not be a blocker.

@meets2tarun
Copy link
Member

@rahulkumaran Go for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants