-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove HTML sanitizer #3956
Comments
@iamareebjamal i would like to work on this, can you help me out? |
You can start with beginner-friendly issues |
people have already called dibs on most the issues. i will still explore. |
HTML-sanitizer has been relaced with dompurify 180 KB -> 16 KB Reopening to completely remove sanitizer from frontend |
@iamareebjamal Can I work on this? |
Not a priority now. Work on newly raised issues. |
I am not finding any instance of html-sanitizer in the project currently. Feel free to reopen if you find something. @pc-beast @progmatic-99 |
https://github.com/apostrophecms/sanitize-html#browser
It is meant to be used in node servers. Not browsers. It takes up a huge chunk of bundle as well.
As written in the repo, think, why do you need to sanitize HTML on client? That is the job of server. Besides I believe, we shouldn't even be storing HTML in backend. It should store markup like markdown, not DOM (#2493). Most people are not using our rich descriptions feature and it is needlessly storing
<p>
tags in DB without any reasonTrigger Reason: We need to allow polyfills of node dependencies like path in order to include it in the build - embroider-build/ember-auto-import#224 (comment)
As ember-auto-import now correctly removes node builtins being polyfilled
Edit:
HTML-sanitizer has been relaced with dompurify
180 KB -> 16 KB
We still have to remove sanitization from frontend, its role of the backend
The text was updated successfully, but these errors were encountered: