Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong error and pointer for unverified user #6394

Closed
liveHarshit opened this issue Aug 19, 2019 · 7 comments · Fixed by #6395
Closed

Wrong error and pointer for unverified user #6394

liveHarshit opened this issue Aug 19, 2019 · 7 comments · Fixed by #6395

Comments

@liveHarshit
Copy link
Member

Reference: fossasia/open-event-attendee-android#2287 (comment)

image
image
@shreyanshdwivedi
Copy link
Member

So you need error Please verify your account to order free tickets? And pointer?

@liveHarshit
Copy link
Member Author

So you need error Please verify your account to order free tickets? And pointer?

@iamareebjamal

@iamareebjamal
Copy link
Member

user should be pointer. UNAUTHORIZED should be the error

@shreyanshdwivedi shreyanshdwivedi mentioned this issue Aug 19, 2019
Merged
6 tasks
@liveHarshit
Copy link
Member Author

user should be pointer. UNAUTHORIZED should be the error

Shouldn't it be unverified?

@shreyanshdwivedi
Copy link
Member

I think the error earlier was fine - 'Unverified user cannot buy free tickets'. @liveHarshit?

@iamareebjamal
Copy link
Member

There is no UNVERIFIED HTTP status code https://httpstatuses.com/401

However, I was wrong, it should be 403 FORBIDDEN

HTTP spec should be changed. 401 UNAUTHORIZED should be UNAUTHENTICATED and 403 FORBIDDEN should be UNAUTHORIZED

@liveHarshit
Copy link
Member Author

I think the error earlier was fine - 'Unverified user cannot buy free tickets'. @liveHarshit?

It's detail, see the error title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: error and pointer for unverified user buying free tickets shreyanshdwivedi/open-event-server
3 participants
@iamareebjamal @shreyanshdwivedi @liveHarshit