-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter upcoming events on the basis of their end date and time. #6955
Comments
This shouldn't even be handled on frontend, this should be provided by the server |
Can I work on this issue? |
Go ahead |
why do we use filter, ( starts_at > current_time or ends_at > current_time) for the upcoming events, when we can only use (ends_at > current_time) as ends_at time is always greater than starts_at and ends_at is never empty in any published event? |
That's better because then we'll also be showing events which are currently happening |
We can show both the future events and events which are currently happening by only checking ends_at > current_time. We don't need starts_at comparison for that. |
Exactly |
Describe the bug
Currently the events are being filtered on the basis of end date only. If an event is single day event of 2hrs, then the vent will get removed from upcoming events on the next day. The event should not be shown in upcoming events if it is over.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
Once the event is over, it should not be shown in the upcoming events or browse events.
Screenshots
Additional context
I am working on this issue.
The text was updated successfully, but these errors were encountered: