Remove repetitive safe_query

[iamareebjamal]

You'll find a lot of unnecessary and repetitive safe_query calls like safe_query(db, Session, 'id', view_kwargs['session_id'], 'session_id')

First of all, all of this should be abstracted, manually calling this is the ultimate source of bugs. However, that will take massive restructuring of the project and hence, for now, just refactor it to be simpler, like safe_query_kwargs(Session, view_kwargs, 'session_id'), that's all the info it needs to do its thing, no need for extra verbosity. If possible, change to safe_query_by_id(Session, view_kwargs['session_id'])

[iamareebjamal]

See last commit of #6997 for more info

[satya7289]

@iamareebjamal I want to work on this issue.

[prateekj117]

@satya7289 Go ahead.

[satya7289]

I think @iamareebjamal has already been resolved this issue.

[iamareebjamal]

Not really?

[satya7289]

I got it. I have to convert the all safe_query(Session, 'id', view_kwargs['session_id'], 'session_id')

1. self_query_by_id(Session,view_kwargs['session_id']) if view_kwargs['session_id']=='session_id'. and second parameter is 'id'.

Am I right? . @iamareebjama

[iamareebjamal]

No, you need to create a new method which takes the dictionary and key and does the same thing as safe query but without repetition

[satya7289]

No, you need to create a new method which takes the dictionary and key and does the same thing as safe query but without repetition

I'm actually new in this, I do not understand 'safe query but without repetition' part, need some more clarification. @iamareebjamal

[iamareebjamal]

You have to change safe_query(db, Session, 'id', view_kwargs['session_id'], 'session_id') into safe_query_kwargs(Session, view_kwargs, 'session_id') so there's no repetition