Move images in public folder into "images" in src folder

[mariobehling]

All source files including images should be in the src folder.

[Remorax]

I would like to take this up :)

[Remorax]

Oh, I didn't notice your comment. I was in the process of creating a PR myself :P

[anshumanv]

@Remorax will you be sending another PR or can I send one? 😄

[Remorax]

Sure, go ahead @anshumanv :)

[anshumanv]

Alright, thanks @Remorax 👍

[anshumanv]

@mariobehling the scaffolding tool we use is create-react-app which has some restrictions attached. They expect all of the static files(which are copied directly while bundling the app) like favicon etc in the public folder and once we run npm run build to package a production build these files are directly copied to the build folder that is generated. So moving favicon to src/images isn't possible with the current version of CRA. For reference please see - facebook/create-react-app#585

[abishekvashok]

@anshumanv we could have pre compile script that we should run before npm install in the app.json which copies images to public folder for us and at last cleans up the folder, what do you think?

[anshumanv]

We can always go for such workarounds, but I'd suggest sticking to the one suggested by cra.

[abishekvashok]

cra.

???

[anshumanv]

create-react-app.

[abishekvashok]

@mariobehling status on this

[0x48piraj]

I can work on this, the other way. (Workaround)