Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of online skills on local device #78

Open
alok760 opened this issue Jul 31, 2019 · 6 comments
Open

Update of online skills on local device #78

alok760 opened this issue Jul 31, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@alok760
Copy link
Member

alok760 commented Jul 31, 2019

The Smart Speaker uses its own SUSI_Server which uses the skills stored in the server itself(https://github.com/fossasia/susi_server) and the SUSI Skill Data - https://github.com/fossasia/susi_skill_data
Implement a system to synchronize skills.

@alok760 alok760 changed the title Synchronise the online skills Synchronization of online skills with local device. Jul 31, 2019
@norbusan
Copy link
Member

What do you mean with synchronize? Two-way synchronization is hard.
Downloading from upstream (git pull) is already happening in the normal update daemon

update_repo susi_skill_data master || do_reboot=1

@alok760
Copy link
Member Author

alok760 commented Jul 31, 2019

@mariobehling can you please clarify on what is needed? You asked me to open an issue for this on Gitter. Do we just have to update the skills ?

@mariobehling
Copy link
Member

We discussed this specific point in the meetings and decided that for public skills we only synchronize from SUSI.AI to the local device. Public skills should not be writable on the local device. A message should be displayed, if the user tries to edit them:

"You are trying to edit public Open Source skills on your local device. These skills are continuously developed together with the community on the online platform. Please login to SUSI.AI to edit public skills.

Hint Icon: Public skills are regularly updated on your device."

@mariobehling mariobehling added the enhancement New feature or request label Jul 31, 2019
@mariobehling
Copy link
Member

Downloading from upstream (git pull) is already happening in the normal update daemon

This feature should also be visible to users. Furthermore it should be possible to trigger this feature in the UI.

@mariobehling mariobehling changed the title Synchronization of online skills with local device. Update of online skills on local device Jul 31, 2019
@mariobehling
Copy link
Member

I think the word synchronization could be misleading. Let's rather call this "Update" of skills on the local device.

@norbusan
Copy link
Member

norbusan commented Aug 5, 2019

Agreed. Public skills are updated via the normal update daemon, and we could add a button somewhere to trigger an update, but private skills should be creatable and editable on the device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants