Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken placeholders in all examples #1089

Open
jensenbox opened this issue Dec 18, 2021 · 0 comments
Open

Broken placeholders in all examples #1089

jensenbox opened this issue Dec 18, 2021 · 0 comments

Comments

@jensenbox
Copy link

I fully recognize that the content is at the discretion of the end user of the templates however I am seeing that the templates are not currently rendering correctly from the website as the placehold.it service is now considered defunct and there are images referencing this now defunct service and therefore not rendering cleanly.

https://placehold.it/ is used for image placeholders, this service is now dead and has been replaced by https://placeholder.com

As validation, on this page https://get.foundation/emails/templates/basic.html you will see a broken image icon. This is because there is an image reference for https://placehold.it/200x50/663399 and if you were to visit that link you will see that the certificate is invalid.

Luckily, the replacement service at https://placeholder.com has an identical URL scheme and is functionally equivalent.

This problem can be remedied with a blanket search and replace.

https://placehold.it gets replaced with https://via.placeholder.com

Additionally, I recommend this operation be performed on all repositories in this organization.

If this is an acceptable solution, I would be happy to craft a few PRs that execute on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant