Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<button> should allow for attributes #592

Closed
cossssmin opened this issue Sep 21, 2016 · 2 comments
Closed

<button> should allow for attributes #592

cossssmin opened this issue Sep 21, 2016 · 2 comments
Milestone

Comments

@cossssmin
Copy link

cossssmin commented Sep 21, 2016

How can we reproduce this bug?

<button href="#" class="large" align="right">Button Label</button>

What did you expect to happen?

Since <button> generates a table, I would expect it to have the align="right" attribute, just like <columns> do.

What happened instead?

The generated table does not contained the passed attribute.

What email clients does this happen in?

Viewing HTML source, no need to email client testing.

This would be useful for aligning buttons on their own, no need to complicate things with columns. not just alignment, any HTML or custom attributes one might need to pass.

@cossssmin
Copy link
Author

Looks like someone already created a PR, almost 3 months ago: @yvmarques, foundation/inky#61

@rafibomb
Copy link
Member

Merged foundation/inky#61

@rafibomb rafibomb added this to the 2.2.2 milestone Sep 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants