Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PositionClass option is ignored by Dropdown 6.3.1 #10178

Closed
Lazerproof opened this issue Jun 13, 2017 · 3 comments
Closed

PositionClass option is ignored by Dropdown 6.3.1 #10178

Lazerproof opened this issue Jun 13, 2017 · 3 comments
Assignees
@DanielRuf
Labels
Dropdown information needed PR open

Comments

@Lazerproof
Copy link

'this.options.positionClass' is set to the value of _getPositionClass without checking for the prior existance of the option during init of Dropdown

How can we reproduce this bug?

  1. Set the positionClass option
  2. It has no effect

What did you expect to happen?

The position should respect the positionClass option

What happened instead?

The position is regexed from the classname instead
@andycochran
Copy link
Contributor

Is this still an issue in 6.4.3?

@DanielRuf
Copy link
Contributor

DanielRuf commented Mar 10, 2018 •
edited
Loading

DEPRECATED: Class applied to adjust open position.

https://github.com/zurb/foundation-sites/blob/477563de08ae39c69ebf40b87f10f871696956c4/js/foundation.dropdown.js#L371-L376

@DanielRuf DanielRuf self-assigned this Mar 10, 2018
@DanielRuf DanielRuf mentioned this issue Mar 10, 2018
Merged
@DanielRuf
Copy link
Contributor

Closing as #11038 is merged.

This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRuf DanielRuf

Labels
Dropdown information needed PR open
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andycochran @DanielRuf @colin-marshall @Lazerproof