Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Snippet Missing 'left' for Off-Canvas #10548

Closed
mandimey opened this issue Aug 16, 2017 · 3 comments
Closed

Code Snippet Missing 'left' for Off-Canvas #10548

mandimey opened this issue Aug 16, 2017 · 3 comments
Assignees
@DanielRuf
Labels
📖 documentation PR open

Comments

@mandimey
Copy link
Contributor

Yo Rafi!

In the code snippet for the off-canvas panel and button, the IDs don't match. As a result, the button doesn't trigger the panel to slide. The panel ID is offCanvas and the button toggle is offCanvasLeft. See http://foundation.zurb.com/sites/docs/off-canvas.html#complete-example + Click Trigger section.

<3
@JeremyEnglert
Copy link

@mandimey - would you like to submit a Pull Request to fix this?

@DanielRuf DanielRuf self-assigned this Feb 20, 2018
@DanielRuf
Copy link
Contributor

DanielRuf commented Feb 20, 2018 •
edited
Loading

Hi @mandimey, would you have the time to provide a PR and need any assistance or can I provide a PR?

@DanielRuf DanielRuf mentioned this issue Feb 23, 2018
Merged
@DanielRuf
Copy link
Contributor

Closimg as this was fixed with #10981

This was referenced Jun 16, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielRuf DanielRuf

Labels
📖 documentation PR open
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DanielRuf @JeremyEnglert @mandimey