You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Destroying the reveal element should remove the is-reveal-open class from the body element.
What happened instead:
body element retains is-reveal-open class after the reveal element is destroyed.
Browser(s) and Device(s) tested on:
Chrome 60.0.3112.113
Foundation Version(s) you are using:
6.4.3
Test case link:
https://codepen.io/anon/pen/WEqOrB - inside the modal is a link with a click event that destroys the reveal element. It will also print out a boolean determined by whether the body element has the is-reveal-open class or not.
Basically the _destroy method does not cleanup the is-reveal-open class, where as the finishUp method does.
The text was updated successfully, but these errors were encountered:
You may consider the following
var alrt = new Foundation.Reveal($('#myReveal'));
alrt.close();
if ($('body').hasClass('is-reveal-open')) { $('body').removeClass('is-reveal-open'); }
var bl = $('.reveal-overlay').filter(function() { return $(this).css('display') == 'block'; });
$(bl).remove();
I was having this problem and solved it by removing these animation effects on the reveal element: data-animation-in="fade-in-fast" data-animation-out="fade-out"
How to reproduce this bug:
Click on the button to open the modal.
With JS, destroy the open reveal element.
body
element foris-reveal-open
class.What should happen:
Destroying the reveal element should remove the
is-reveal-open
class from thebody
element.What happened instead:
body
element retainsis-reveal-open
class after the reveal element is destroyed.Browser(s) and Device(s) tested on:
Chrome 60.0.3112.113
Foundation Version(s) you are using:
6.4.3
Test case link:
https://codepen.io/anon/pen/WEqOrB - inside the modal is a link with a click event that destroys the reveal element. It will also print out a boolean determined by whether the
body
element has theis-reveal-open
class or not.Basically the
_destroy
method does not cleanup theis-reveal-open
class, where as thefinishUp
method does.The text was updated successfully, but these errors were encountered: