Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new ignored_warnings_from (ignored_file_paths) config setting #1114

Closed
mattsse opened this issue Feb 9, 2024 · 6 comments · Fixed by #1305
Closed

Document new ignored_warnings_from (ignored_file_paths) config setting #1114

mattsse opened this issue Feb 9, 2024 · 6 comments · Fixed by #1305
Assignees
@mabsattar
Labels
good first issue Good for newcomers T-new Type: new docs

Comments

@mattsse
Copy link
Member

mattsse commented Feb 9, 2024 •
edited
Loading

ref foundry-rs/foundry#7063

https://book.getfoundry.sh/reference/config/solidity-compiler

cc @loocapro
@Evalir Evalir added the good first issue Good for newcomers label Feb 9, 2024
@mabsattar
Copy link
Contributor

Hi, I would like to work on this, can you assign me.

@mattsse
Copy link
Member Author

mattsse commented Feb 9, 2024

assigned, ty

@zerosnacks zerosnacks mentioned this issue Sep 16, 2024
Open
7 tasks
@zerosnacks zerosnacks added the T-new Type: new docs label Sep 17, 2024
@zerosnacks
Copy link
Member

Hi @mabsattar are you still interested in working on this?

@mabsattar
Copy link
Contributor

hi @zerosnacks thank you for reminding me, I just saw that this is still pending.
Can I work on it now and fix it ASAP.
I'll update you once its done or if I face any issues.

@zerosnacks
Copy link
Member

Thanks @mabsattar, no worries

@mabsattar
Copy link
Contributor

Hi @mattsse @zerosnacks , sent the PR for this, please let me know if any changes needed. thanks

@zerosnacks zerosnacks changed the title Document new ignored_warnings_from config setting Document new ignored_file_paths config setting Sep 17, 2024
@zerosnacks zerosnacks changed the title Document new ignored_file_paths config setting Document new ignored_warnings_from (ignored_file_paths) config setting Sep 17, 2024
@zerosnacks zerosnacks mentioned this issue Sep 17, 2024
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Foundry Book Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mabsattar mabsattar

Labels
good first issue Good for newcomers T-new Type: new docs
Projects
No open projects
Foundry Book
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: document ignored_warnings_from setting mabsattar/book
4 participants
@mattsse @Evalir @mabsattar @zerosnacks