Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different mumbai aliases #427

Open
klkvr opened this issue Aug 7, 2023 · 1 comment
Open

Different mumbai aliases #427

klkvr opened this issue Aug 7, 2023 · 1 comment

Comments

@klkvr
Copy link
Member

klkvr commented Aug 7, 2023

Right now, the most convinient way to name chains in config is by following naming used in Chains enum in ethers-rs (as discussed is foundry-rs/foundry#4895). For mumbai network this alias is mumbai (polygon-mumbai is also fine, but mumbai seems to be the preferred one)
https://github.com/gakonst/ethers-rs/blob/3e7606d81b423593db5a38dcf3b5174987efc74c/ethers-core/src/types/chain.rs#L99-L101

But following such pattern for this network results in it being non-found by StdChains, because it uses polygon_mumbai alias:

forge-std/src/StdChains.sol

Lines 204 to 206 in f18e8aa

setChainWithDefaultRpcUrl(
"polygon_mumbai", ChainData("Polygon Mumbai", 80001, "https://rpc-mumbai.maticvigil.com")
);

I think that it will make sense to change alias in initializeStdChains to mumbai and fix all such differences

@mds1
Copy link
Collaborator

mds1 commented Aug 7, 2023

polygon_mumbai has been present for a long time, so this would be a breaking change that I'd like to avoid. Perhaps there's a way to cleanly support aliases though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants