Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider add permissionless mint and burn for MockERC20 #590

Closed
robinsdan opened this issue Jul 29, 2024 · 1 comment
Closed

Consider add permissionless mint and burn for MockERC20 #590

robinsdan opened this issue Jul 29, 2024 · 1 comment

Comments

@robinsdan
Copy link

This contract was proposed in #469, and the mint/burn function was not included because the balance can be set through "deal". At the same time, it can be easily added if needed.

However, the absence of mint/burn poses two inconveniences:

  1. "deal" can only be used for local testing, which means that when the contract needs to be deployed to the testnet, a new contract with "mint" needs to be re-implemented.
  2. Using "deal" results in a significant number of additional calls, making the call trace very cumbersome.
@zerosnacks
Copy link
Member

MockERC20 has been deprecated from forge-std in: #643

It is recommended to create mocks around the ERC20 library you are using in your project.

@zerosnacks zerosnacks closed this as not planned Won't fix, can't repro, duplicate, stale Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants